search

mattprecious / telescope

A simple tool to allow easy bug report capturing within your app.
Apache License 2.0
1.18k stars 116 forks source link

Google Maps in a screenshot #21

Closed tasomaniac closed 8 years ago

tasomaniac commented 9 years ago

When I have Google Maps in the hierarchy the screenshot shows just a black surface. Here is the screenshot taken with Telescope.

telescope-2015-09-08-100034

I think #13 would fix this for > Lollipop devices.

mattprecious commented 9 years ago

I believe this is a similar issue to #18. Another team internally has worked around this by manually invalidating the drawing cache when telescope is triggered. I'll try to dig up the code and put together a sample.

athkalia commented 8 years ago

That would be lovely, I am facing the same issue

ZacSweers commented 8 years ago

This can be closed with version 2.0 right?

stkent commented 8 years ago

The 2.0.0 release notes suggest that this will no longer be a problem on 21+, not sure about 20 and below.

mattprecious commented 8 years ago

Yeah, this shouldn't be an issue anymore on 21+ unless the user denies the permission to record the screen. I'd still like to solve this for pre-21, though... @tasomaniac, you made the change to Lens to be able to solve this, right? Can you post a sample somewhere?

tasomaniac commented 8 years ago

Sorry all I have it for devices below 21 in my codebase. It's in my to do list to open a pr here. I couldn't find time yet. I will do it soon.

I don't want to include play Services to your sample. Should I do that? Or should I add another sample module with GMS just for maps?

On Mon, Feb 15, 2016, 19:54 Matthew Precious notifications@github.com wrote:

Yeah, this shouldn't be an issue anymore on 21+ unless the user denies the permission to record the screen. I'd still like to solve this for pre-21, though... @tasomaniac https://github.com/tasomaniac, you made the change to Lens to be able to solve this, right? Can you post a sample somewhere?

— Reply to this email directly or view it on GitHub https://github.com/mattprecious/telescope/issues/21#issuecomment-184323950 .

mattprecious commented 8 years ago

Unless it's going to crash on emulators without play services then I don't mind adding it to the sample.