Bump Gradle, AGP and target/compileSdkVersion

rciovati commented 4 years ago

I wanted to look into #75 when I realized I cannot import/build the project with a recent AS version, so here some housekeeping:

Bump Gradle to 5.6.2
Bump AGP to 3.5.0
~Bump compile/targetSdkVersion to 28. My assumption is that bumping to 29 will break the library (see #75) so for now I'd leave 28. On top of that, the latest support lib is 28.x.x so I'd rather move to AndroidX before changing that. Happy to do it in a separate PR.~
As per @JakeWharton's comments it also bump compile/targetSdkVersion to 29

JakeWharton commented 4 years ago

Changing to 29 won't affect the library or its users directly so there's no reason to hold off on it.

rciovati commented 4 years ago

@JakeWharton right, it won't break the library or its consumers. The sample app now has targetSdkVersion=29 and it breaks but I guess it's a good start to actually fix the issue.

mattprecious commented 4 years ago

Thanks!

mattprecious / telescope

Bump Gradle, AGP and target/compileSdkVersion #76