mattprecious / telescope

A simple tool to allow easy bug report capturing within your app.
Apache License 2.0
1.18k stars 116 forks source link

Run foreground service while capturing #78

Closed julioz closed 4 years ago

julioz commented 4 years ago

Fixes https://github.com/mattprecious/telescope/issues/75 Follow-up to https://github.com/mattprecious/telescope/pull/77

This branch was built on top of https://github.com/mattprecious/telescope/pull/76, to leverage the version bumps and also the crash reproducibility. Please consider merging that PR (it also means the diff for this one is smaller than it looks).

You can follow the commit history for easier understanding of the changes, but in summary:

Open question: Since the foreground service requires a notification, and thus a notification channel, I hardcoded some values for simplicity (like notification channel name, service ID, notification ID, and didn't define a notification icon). Is this something users of the library absolutely care about, and if so, would it be worth providing a public API via telescope's configuration methods to define them?

mattprecious commented 4 years ago

This looks good. Can you rebase on master?

julioz commented 4 years ago

@mattprecious Done, thanks for the ping.

mattprecious commented 4 years ago

Thanks!