search

mattrasto / phase

Network visualization framework for complex systems and simulations
MIT License
9 stars 1 forks source link

Validate element ids for HTML/CSS id compliance #89

Closed mattrasto closed 5 years ago

mattrasto commented 5 years ago

If the network data contains elements with ids that may not be correctly parsed/recognized by HTML/CSS selectors, some functionality may break. For example, nodes with ids containing periods will cause static layout node dragging to fail because we cannot select on HTML element ids containing periods.

This should be built into data integrity checks (#65) and properly tested for.

sergeichestakov commented 5 years ago

HTML 5 standard for IDs just requires that they are at least one character and do not contain spaces. Why do periods break functionality and what causes this to happen? What specifically do we have to watch out for that is not parseable?

mattrasto commented 5 years ago

Indeed, the issue was with query selectors requiring the escaping of some characters (notably, periods and semicolons). This has been implemented in 188ad203bbb5459e42b26f129ff02ef49ac79b31 using this snippet from jQuery's website - could you implement checks for single-character ids and spaces?