search

mattray / spiceweasel

Generates Chef knife commands from a simple JSON or YAML file.
Apache License 2.0
284 stars 65 forks source link

Berkshelf support #27

Closed chrisroberts closed 11 years ago

chrisroberts commented 11 years ago

Adds support for processing a Berkshelf file

mattray commented 11 years ago

Wow, just getting to my GitHub notices after a week of travel. It's like Xmas in January! I'll try to get to all of these PRs in the next week for sure.

chrisroberts commented 11 years ago

@mattray Some of the pull requests I have open may conflict a bit with each other. After review I can get them merged down into one or two pull requests if it would make things easier. Everything all mashed into one branch is hanging out here: https://github.com/chrisroberts/spiceweasel/tree/edge-stable

mattray commented 11 years ago

I'll work off of that branch then.

jdutton commented 11 years ago

The addition of 'dep_selector' to the spiceweasel.gemspec breaks Windows compatibility. Is it really needed? I'm testing @chrisroberts edge-stable branch without it to see if I can use a berksfile.

chrisroberts commented 11 years ago

@jdutton I added it to get proper dependency resolution fixing things like #21. I can swap it out with Solve, which is what Berkshelf is using internally. I don't believe it has any issues on windows.

jdutton commented 11 years ago

Solve is better for Windows, but what is Chef 11 using for a solver? It's ditched gecode/depsolver, but I'm not sure what has replaced it.

spheromak commented 11 years ago

I dunno if this is my merge Issue or not, but when I am using berkshelf support the spiceweasel cookbook validator will always complain that a cookbook can't be found. Even when its in berks. I may look at that a bit more, but for now I've just turned off validation. Thought I would bring it up here.

chrisroberts commented 11 years ago

@spheromak Do you have the berksfile option set in the config?

spheromak commented 11 years ago

@chrisroberts Yea it is resolving and uploading, but it fails on the dep check. All my cooks in my berksfile are in groups. That maybe has something to do with it ?

Using berksfile: Berksfile at the top of my spiceweasel yml and have no cookbooks: section

chrisroberts commented 11 years ago

@spheromak Ah, that may be the case. If you provide a berksfile without the grouping, do things work as expected? I'll see about throwing the group support in as it should be pretty easy.

spheromak commented 11 years ago

@chrisroberts I'll do a test in a bit and see. Gotta get some stuff working for a meeting first :)

williampratt commented 11 years ago

Any news on this. We are very interested in using spiceweasel with Berkshelf.

williampratt commented 11 years ago

Also, if there is anything I can do to help, please let me know. I should have stated that in my comment yesterday.

chrisroberts commented 11 years ago

@williampratt i have some updates hanging out in my edge-stable branch. I am working locally on refactoring and cleaning it up a bit and will be kicking out a new single pull request that covers all of the ones I currently have open. I have pulled depselector back out from my branch, but I still have some updates/refactoring to do around that. If you want to just test it in use, that would be a huge help just to identify any issues that may arise from use cases that don't apply to my usage specifically.

williampratt commented 11 years ago

Ok, I'd be happy to do so. I'll see if I can't get to it today or tomorrow at the latest. Thanks for the quick reply.

spheromak commented 11 years ago

@chrisroberts I've been using your unified patches and a couple other hand merged pr's for a while now on my own integration branch here. The Berkshelf support seems to work great, and I haven't ran into any issues.

chrisroberts commented 11 years ago

Closing this out for: https://github.com/mattray/spiceweasel/issues/35