mattrayner / cordova-plugin-vuforia

A 'simple' Vuforia based image recognition plugin for Cordova
MIT License
59 stars 39 forks source link

Removed the NavigationController #84

Closed Stending closed 8 years ago

Stending commented 8 years ago

Description

We discovered that using a UINavigationController to display the Camera and use Vuforia is not necessary!

Motivation and Context

That NavigationController implementation isn't compatible with some other cordova plugins (like cordova-plugin-screen-orientation in our case). So I just removed it and replaced it. Now everything is more simple, the AppDelegate.m is no longer modified, and there is no more conflicts with other plugins!

Fixes #16

How Has This Been Tested?

Tested on iPad and iPod Touch

Screenshots (if appropriate):

Types of changes

mattrayner commented 8 years ago

Does this also need to be changed for Android? It's important that both platforms behave the same

Stending commented 8 years ago

Nope, that concern the change of the AppDelegate.m, it's for iOS only!

mattrayner commented 8 years ago

Awesome, I've merged it in and will do some thorough testing tonight