Fixed the bug when Vuforia stop working when orientation changes on iOS. - Githubissues

mattrayner / cordova-plugin-vuforia

A 'simple' Vuforia based image recognition plugin for Cordova

MIT License

59 stars 39 forks source link

Fixed the bug when Vuforia stop working when orientation changes on iOS. #90

Closed Stending closed 8 years ago

Stending commented 8 years ago

Description

We just discovered that Vuforia stop working when the orientation changes. So I just added few lines that fix that!

How Has This Been Tested?

Tested on iPod Touch.

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[x] I have read the CONTRIBUTING document.

mattrayner commented 8 years ago

Your previous PR #84 has introduced some instability to the code base - I will be unable to merge this until this issue has been fixed. Please see #91

mattrayner commented 8 years ago

Once you have addressed the commented code above and rebased, I'd be happy to consider this pull request

mattrayner commented 8 years ago

Hi @Stending if you rebase this off of master and reply to the comments I'll merge this in

mattrayner commented 8 years ago

Any movement on this?

dsgriffin commented 8 years ago

@mattrayner Did you manage to recreate this issue? I haven't had any issues with the orientation, but if you can, we can add the code in ourselves if Stending isn't around anymore

mattrayner commented 8 years ago

I can't say I have - I'm going to close this for now unless @Stending comes back