mattrayner / cordova-plugin-vuforia

A 'simple' Vuforia based image recognition plugin for Cordova
MIT License
59 stars 39 forks source link

Update support for Vuforia to 5.5 #97

Closed mattrayner closed 8 years ago

mattrayner commented 8 years ago

Description

We're making changes to the plugin to support the Vuforia 5.5.9 APIs.

Motivation and Context

We want to support cloud recognition [#88] and in order to do this using the latest codebase and documentation, we should update.

This will hopefully make the Vuforia section of our application more stable too!

Fixes #96

How Has This Been Tested?

iPhone 6S running iOS10 beta 3

Types of changes

mattrayner commented 8 years ago

@dsgriffin ignore the failing dependency check - that's a BitHound issue, I'm in touch with support now trying to fix it

mattrayner commented 8 years ago

@dsgriffin can you check this on your Android device and report back?

I'm seeing an issue where opening one of the tests, then a second one causes the Vuforia app to break. My device is super old and I'm not sure if it's that, or an issue with the upgrade

mattrayner commented 8 years ago

I've discovered some issues with the Android code base - re-opening Vuforia i.e. scanning a target, recognising and then relaunching, is broken.

Working on a fix now

dsgriffin commented 8 years ago

@mattrayner Cool - actually trying to get my S4 Mini to turn on at the moment, might have to reset it or something as charging it isn't helping.

Let me know when you've updated the fix and hopefully I'll have my phone working and we can merge.

mattrayner commented 8 years ago

@dsgriffin I've implemented a fix - the code's not particularly neat, but it works and we should re-factor after this update anyways - there's been a few API changes

mattrayner commented 8 years ago

@dsgriffin I have REVd the version number on this PR in preparation for release too :+1:

dsgriffin commented 8 years ago

@mattrayner import com.qualcomm.vuforia.State; in ApplicationControl.java needs to be changed to import com.vuforia.State; for it to work; not coming across any other issues though

mattrayner commented 8 years ago

@dsgriffin I've made that change for you :+1:

dsgriffin commented 8 years ago

Cool - looks good to merge then.

mattrayner commented 8 years ago

:+1: Do you think this should be a minor or bug fix? There's technically no API changes?

dsgriffin commented 8 years ago

Usually it'd be a bug fix but as it's upgrading the library by a whole version I'm not sure - I'd probably do a minor but either would be fine 👍

mattrayner commented 8 years ago

Cool, I previously REVd to 3.2.0 so I'll release it under that :smile: