Closed mattrayner closed 8 years ago
@dsgriffin ignore the failing dependency check - that's a BitHound issue, I'm in touch with support now trying to fix it
@dsgriffin can you check this on your Android device and report back?
I'm seeing an issue where opening one of the tests, then a second one causes the Vuforia app to break. My device is super old and I'm not sure if it's that, or an issue with the upgrade
I've discovered some issues with the Android code base - re-opening Vuforia i.e. scanning a target, recognising and then relaunching, is broken.
Working on a fix now
@mattrayner Cool - actually trying to get my S4 Mini to turn on at the moment, might have to reset it or something as charging it isn't helping.
Let me know when you've updated the fix and hopefully I'll have my phone working and we can merge.
@dsgriffin I've implemented a fix - the code's not particularly neat, but it works and we should re-factor after this update anyways - there's been a few API changes
@dsgriffin I have REVd the version number on this PR in preparation for release too :+1:
@mattrayner import com.qualcomm.vuforia.State;
in ApplicationControl.java
needs to be changed to import com.vuforia.State;
for it to work; not coming across any other issues though
@dsgriffin I've made that change for you :+1:
Cool - looks good to merge then.
:+1: Do you think this should be a minor or bug fix? There's technically no API changes?
Usually it'd be a bug fix but as it's upgrading the library by a whole version I'm not sure - I'd probably do a minor but either would be fine 👍
Cool, I previously REVd to 3.2.0 so I'll release it under that :smile:
Description
We're making changes to the plugin to support the Vuforia 5.5.9 APIs.
Motivation and Context
We want to support cloud recognition [#88] and in order to do this using the latest codebase and documentation, we should update.
This will hopefully make the Vuforia section of our application more stable too!
Fixes #96
How Has This Been Tested?
iPhone 6S running iOS10 beta 3
Types of changes
Checklist: