Closed raygoe closed 2 years ago
Fixed in beta, thanks
On 25/04/2022 5:39 am, Eric Christian wrote:
On clang12, I get this error:
error: constexpr function's return type 'plf::hive_limits' is not a literal type constexpr static inline plf::hive_limits block_capacity_hard_limits() noexcept note: 'hive_limits' is not literal because it is not an aggregate and has no constexpr constructors other than copy or move constructors struct hive_limits // for use in block_capacity setting/getting functions and constructors
Adding constexpr on the constructor for hive_limits fixes it. Tested MSVC and Clang.
You can view, comment on, or merge this pull request online at:
https://github.com/mattreecebentley/plf_hive/pull/13 https://github.com/mattreecebentley/plf_hive/pull/13
Commit Summary
- 9f0c1f6 https://github.com/mattreecebentley/plf_hive/pull/13/commits/9f0c1f6485b9bd9ea657465fb9b1b1171feb245b Fixed an issue with clang compilation.
62816ca https://github.com/mattreecebentley/plf_hive/pull/13/commits/62816cae6a9573e90883da92fc71cfb89495cf7e Merge pull request #1 from raygoe/raygoe-patch-1
File Changes
(1 file https://github.com/mattreecebentley/plf_hive/pull/13/files)
M plf_hive.h https://github.com/mattreecebentley/plf_hive/pull/13/files#diff-32c2d2d70cc51caff8e906577e1188f330416501f24ed8f89b78bfae65c791c2 (2)
Patch Links:
https://github.com/mattreecebentley/plf_hive/pull/13.patch https://github.com/mattreecebentley/plf_hive/pull/13.patch
https://github.com/mattreecebentley/plf_hive/pull/13.diff https://github.com/mattreecebentley/plf_hive/pull/13.diff
— Reply to this email directly, view it on GitHub https://github.com/mattreecebentley/plf_hive/pull/13, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABE4FIX3NMYED2L7AXCCB63VGWBO3ANCNFSM5UGRL7QQ. You are receiving this because you are subscribed to this thread.Message ID: @.***>
On clang12, I get this error:
error: constexpr function's return type 'plf::hive_limits' is not a literal type constexpr static inline plf::hive_limits block_capacity_hard_limits() noexcept note: 'hive_limits' is not literal because it is not an aggregate and has no constexpr constructors other than copy or move constructors struct hive_limits // for use in block_capacity setting/getting functions and constructors
Adding constexpr on the constructor for hive_limits fixes it. Tested MSVC and Clang.