mattrglobal / bbs-signatures

An implementation of BBS+ signatures for node and browser environments
Apache License 2.0
109 stars 30 forks source link

Strict check for given messages count and originally revealed #110

Closed anton-iskryzhytskyi closed 2 years ago

anton-iskryzhytskyi commented 2 years ago

Description

Motivation and Context

The main point of this PR is to restrict providing more messages to the blsVerifyProof than it was revealed originally. For now it is possible to provide all revealed + signed messages in the right order and then add to the messages array some additional, not signed, not revealed messages and receive a successful response result.verified === true. More details in the issue

Does this PR introduce a breaking change?

Which merge strategy will you use?

anton-iskryzhytskyi commented 2 years ago

@tplooker this PR is blocked by realizing new version of node-bbs-signature, so I would ask you to release it first, then I can update yarn-lock and tests for node env should pass successfully. If I can help with this process, please let me know.

anton-iskryzhytskyi commented 2 years ago

@tplooker, I update peer-dep node-bss-signatures so, let's check this PR (the same fix as for node-bss-signatures)

tplooker commented 2 years ago

@anton-iskryzhytskyi can you please make the change I suggested, then im happy to merge your PR

tplooker commented 2 years ago

@anton-iskryzhytskyi i've managed to update your PR through suggestions, merging now