feat(types): convert exports to explicit type exports

kad-busses commented 1 year ago

Description

[ ] Tests for the changes have been added (for bug fixes / features)
[x] The commit message(s) follow conventional commits
[ ] Documentation has been added / updated (for bug fixes / features)
[x] Changes follow the contributing document.

Motivation and Context

Types cannot be re-exported when using the --isolatedModules TypeScript compiler flag. For some transpilers (Babel for example) this flag is mandatory, making it impossible to add this package.

TypeScript has a Type-Only Imports and Export feature, which addresses this issue. This PR converts the type exports to explicit types.

Closes https://github.com/mattrglobal/bbs-signatures/issues/69

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Which merge strategy will you use?

[x] Squash
[ ] Rebase (REVIEW COMMITS)

trevormil commented 5 months ago

Running into the same problem. I am doing this manually. Would love for this to be added to the npm package :)

truonghaha commented 2 months ago

Hi team, we are experiencing the same issue. Just wonder why this PR has been open for a year without approval? 😅

trevormil commented 2 months ago

Hi team, we are experiencing the same issue. Just wonder why this PR has been open for a year without approval? 😅

Hey.

If you need, I created a fork with this fixed at

npm i @trevormil/bbs-signatures

mattrglobal / bbs-signatures