mattrglobal / bls12381-key-pair

A library for using BLS 12-381 key pairs
Apache License 2.0
15 stars 10 forks source link

feat: add support to convert to and from JWKs #25

Closed kdenhartog closed 4 years ago

kdenhartog commented 4 years ago

re #12

Description

Motivation and Context

Does this PR introduce a breaking change?

Which merge strategy will you use?

github-actions[bot] commented 4 years ago

Total Coverage: 98.25%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
src
   Bls12381G2KeyPair.ts91.30%95.24%97.65%110, 111, 113, 185, 284, 291
   index.ts100%100%100%
src/types
   BlsCurveName.ts100%100%100%
   index.ts100%100%100%
src/utils
   codec.ts100%100%100%
   index.ts100%100%100%
src/validators
   Bls12381G2Jwk.ts100%100%100%
   JsonWebKey.ts100%100%100%
   index.ts100%100%100%
kdenhartog commented 4 years ago

Added tests now as well to keep test coverage up and removed the breaking changes. Should be all good to go now.

github-actions[bot] commented 4 years ago

Total Coverage: 98.25%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
src
   Bls12381G2KeyPair.ts91.30%95.24%97.65%110, 111, 113, 185, 284, 291
   index.ts100%100%100%
src/types
   BlsCurveName.ts100%100%100%
   index.ts100%100%100%
src/utils
   codec.ts100%100%100%
   index.ts100%100%100%
src/validators
   Bls12381G2Jwk.ts100%100%100%
   JsonWebKey.ts100%100%100%
   index.ts100%100%100%
github-actions[bot] commented 4 years ago

Total Coverage: 98.25%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
src
   Bls12381G2KeyPair.ts91.30%95.24%97.65%110, 111, 113, 185, 284, 291
   index.ts100%100%100%
src/types
   BlsCurveName.ts100%100%100%
   index.ts100%100%100%
src/utils
   codec.ts100%100%100%
   index.ts100%100%100%
src/validators
   Bls12381G2Jwk.ts100%100%100%
   JsonWebKey.ts100%100%100%
   index.ts100%100%100%
kdenhartog commented 4 years ago

1st force push was to update the strings to remove the hyphens. The second one was to removed an unused import in the test file.

github-actions[bot] commented 4 years ago

Total Coverage: 98.25%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
src
   Bls12381G2KeyPair.ts91.30%95.24%97.65%110, 111, 113, 185, 284, 291
   index.ts100%100%100%
src/types
   BlsCurveName.ts100%100%100%
   index.ts100%100%100%
src/utils
   codec.ts100%100%100%
   index.ts100%100%100%
src/validators
   Bls12381G2Jwk.ts100%100%100%
   JsonWebKey.ts100%100%100%
   index.ts100%100%100%