mattrglobal / ffi-bbs-signatures

An FFI wrapper around the implementation of BBS+ signatures in Ursa
Apache License 2.0
23 stars 23 forks source link

BBS+ Signatures FFI Wrapper for Python #22

Closed karimStekelenburg closed 3 years ago

karimStekelenburg commented 3 years ago

Contains a wrapper for Python. Tests and test pipelines are included for macOS, Linux and Windows.

TODOs:

karimStekelenburg commented 3 years ago

Hi @tplooker @andrewwhitehead @swcurran! Here is my PR for the Python wrapper. I was wondering what the right approach is for releasing it to PyPi, we were thinking the Hyperledger account might be the best place for it. Any thoughts on this?

Thanks!

tmarkovski commented 3 years ago

I was wondering what the right approach is for releasing it to PyPi, we were thinking the Hyperledger account might be the best place for it. Any thoughts on this?

Same question for the .NET wrapper. Would be great to add Nuget publishing. We're currently doing it from a fork.

swcurran commented 3 years ago

Love to see this reviewed, accepted if appropriate, and a way to get the artifacts published. @tplooker @kdenhartog @mikelodder7

Thanks!

tplooker commented 3 years ago

Thanks @karimStekelenburg this looks great!

I was wondering what the right approach is for releasing it to PyPi, we were thinking the Hyperledger account might be the best place for it. Any thoughts on this?

I'm currently reviewing a couple of options, we are happy to push out the management of this wrapper to somewhere like hyperledger, if they want to take over maintenance?

karimStekelenburg commented 3 years ago

Thanks @tplooker! I'll make sure to finalize the remaining tasks in the coming days.

If my understanding is correct I believe @andrewwhitehead is one of the maintainers of the Hyperledger PyPi account. @andrewwhitehead if my assumption is correct, would you be willing to push it to the registry? I'll gladly volunteer to help maintaining the code.

andrewwhitehead commented 3 years ago

I'm not a maintainer, Ry Jones usually manages that. Generally you would publish a pypi package first and add Hyperledger as an owner later, and then add the authentication token as a secret on a hyperledger repo to enable workflow-based publishing.

karimStekelenburg commented 3 years ago

Thanks @andrewwhitehead! I've made the changes and I think it’s ready to be merged.

I have added a CI action that pushes the package to PyPi and have published an initial version: ursa-bbs-signatures · PyPI. The publish action will only run when triggered manually, or when a release is created, so this shouldn’t be a blocker for the merge.

I’ll shoot a message to Ry Jones about how to go about the ownership of the package with regards to publishing secrets etc.

ryjones commented 3 years ago

Once this is merged into a hyperledger repo, we can talk about how to publish. it is fairly straightforward.

tplooker commented 3 years ago

PR LGTM, merging as is, then we can co-ordinate next steps around the wrappers home