Closed mikelodder7 closed 4 years ago
github-actions[bot]
commented
4 years ago Total Coverage: 86.96%
| File | Branches | Funcs | Lines | Uncovered Lines |
|---|---|---|---|---|
| src | ||||
| bbsSignature.ts | 100% | 72.73% | 80.95% | 140, 164, 217, 218, 219, 226, 237, 238, 255, 256, 257, 265 |
| bls12381.ts | 83.33% | 100% | 100% | 26 |
| bls12381toBbs.ts | 100% | 100% | 100% | |
| index.ts | 100% | 100% | 100% | |
| src/types | ||||
| BlsKeyPair.ts | 100% | 100% | 100% | |
| index.ts | 100% | 100% | 100% | |
github-actions[bot]
commented
4 years ago Total Coverage: 86.96%
| File | Branches | Funcs | Lines | Uncovered Lines |
|---|---|---|---|---|
| src | ||||
| bbsSignature.ts | 100% | 72.73% | 80.95% | 140, 164, 217, 218, 219, 226, 237, 238, 255, 256, 257, 265 |
| bls12381.ts | 83.33% | 100% | 100% | 26 |
| bls12381toBbs.ts | 100% | 100% | 100% | |
| index.ts | 100% | 100% | 100% | |
| src/types | ||||
| BlsKeyPair.ts | 100% | 100% | 100% | |
| index.ts | 100% | 100% | 100% | |
github-actions[bot]
commented
4 years ago Total Coverage: 86.96%
| File | Branches | Funcs | Lines | Uncovered Lines |
|---|---|---|---|---|
| src | ||||
| bbsSignature.ts | 100% | 72.73% | 80.95% | 140, 164, 217, 218, 219, 226, 237, 238, 255, 256, 257, 265 |
| bls12381.ts | 83.33% | 100% | 100% | 26 |
| bls12381toBbs.ts | 100% | 100% | 100% | |
| index.ts | 100% | 100% | 100% | |
| src/types | ||||
| BlsKeyPair.ts | 100% | 100% | 100% | |
| index.ts | 100% | 100% | 100% | |
Description
This PR updates to use the bbs 0.4.0 crate which comes with following notable changes
Swaps out the underlying library that supplies the BLS12-381 implementation to use
paring_pluswhich gives in some benchmarks a 10x boost in performance (run yarn benchmark on the different versions to compare)The top level API has been simplified further removing the need for totalMessages and revealedIndicies as seperate elements that must be supplied to the API. Instead the proof value now includes this information, following the proposal documented here
[x] Tests for the changes have been added (for bug fixes / features)
[x] The commit message(s) follow conventional commits
[x] Documentation has been added
[ ] Changes follow the contributing document.
Motivation and Context
Does this PR introduce a breaking change?
Which merge strategy will you use?