search

mattrglobal / node-bbs-signatures

An implementation of BBS+ signatures using rust and typescript for node.js
Apache License 2.0
58 stars 27 forks source link

Allow signing verifying and creating proofs of binary data as input rather than string #113

Closed tplooker closed 4 years ago

tplooker commented 4 years ago

Currently the top level API for this library requires the input messages to be an array of strings, this should be changed to be an array of byte arrays.

tplooker commented 4 years ago

@mikelodder7 thoughts, this makes the API more general purpose and more inline with other crypto library APIs?

mikelodder7 commented 4 years ago

Yes, but we need a method of hashing to a scalar exposed like signatureMessage.hash

tplooker commented 4 years ago
  1. Convert the exposed RUST FFI API to deal in byteArrays for messages,
  2. In the JS wrapper layer handle converting string to byteArrays so that there is no breaking change to the exposed API from this library.
tplooker commented 4 years ago

Fixed in #124