mattrglobal / node-bbs-signatures

An implementation of BBS+ signatures using rust and typescript for node.js
Apache License 2.0
58 stars 27 forks source link

feat: change to async based api #136

Closed tplooker closed 3 years ago

tplooker commented 4 years ago

Description

Migrates to an asynchronous based api to maintain an interoperable public interface with other bbs-signature libraries in the TS/JS ecosystem

Motivation and Context

As alluded to in the description in order for TS/JS based bbs-signature libraries to have a common public interface we are shifting this API towards a promise based API.

Does this PR introduce a breaking change?

All API's now return a promise wrapped result

Which merge strategy will you use?

github-actions[bot] commented 4 years ago

Total Coverage: 87.60%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
src
   bbsSignature.ts100%75%79.73%150, 175, 230, 232, 233, 234, 235, 242, 253, 254, 271, 272, 273, 274, 282
   bls12381.ts83.33%100%100%31, 46, 61, 76
   bls12381toBbs.ts100%100%100%
   index.ts100%100%100%
src/types
   BlsKeyPair.ts100%100%100%
   index.ts100%100%100%
github-actions[bot] commented 4 years ago

Total Coverage: 87.60%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
src
   bbsSignature.ts100%75%79.73%150, 175, 230, 232, 233, 234, 235, 242, 253, 254, 271, 272, 273, 274, 282
   bls12381.ts83.33%100%100%31, 46, 61, 76
   bls12381toBbs.ts100%100%100%
   index.ts100%100%100%
src/types
   BlsKeyPair.ts100%100%100%
   index.ts100%100%100%
github-actions[bot] commented 4 years ago

Total Coverage: 87.60%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
src
   bbsSignature.ts100%75%79.73%150, 175, 230, 232, 233, 234, 235, 242, 253, 254, 271, 272, 273, 274, 282
   bls12381.ts83.33%100%100%31, 46, 61, 76
   bls12381toBbs.ts100%100%100%
   index.ts100%100%100%
src/types
   BlsKeyPair.ts100%100%100%
   index.ts100%100%100%
github-actions[bot] commented 4 years ago

Total Coverage: 87.60%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
src
   bbsSignature.ts100%75%79.73%150, 175, 230, 232, 233, 234, 235, 242, 253, 254, 271, 272, 273, 274, 282
   bls12381.ts83.33%100%100%31, 46, 61, 76
   bls12381toBbs.ts100%100%100%
   index.ts100%100%100%
src/types
   BlsKeyPair.ts100%100%100%
   index.ts100%100%100%
github-actions[bot] commented 4 years ago

Total Coverage: 87.60%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
src
   bbsSignature.ts100%75%79.73%150, 175, 230, 232, 233, 234, 235, 242, 253, 254, 271, 272, 273, 274, 282
   bls12381.ts83.33%100%100%31, 46, 61, 76
   bls12381toBbs.ts100%100%100%
   index.ts100%100%100%
src/types
   BlsKeyPair.ts100%100%100%
   index.ts100%100%100%
kdenhartog commented 4 years ago

@tplooker I think this is ready to go. Anything else we need to do to merge it?