feat: add node 18 support - Githubissues

mattrglobal / node-bbs-signatures

An implementation of BBS+ signatures using rust and typescript for node.js

Apache License 2.0

58 stars 27 forks source link

feat: add node 18 support #218

Closed mate-from-mattr closed 1 year ago

mate-from-mattr commented 1 year ago

This library now supports Node 18.

Description

Node 18 added to all GitHub actions.
Fail-fast now activated on the any-pr action - it might fail on one version of Node, but build on another. It is helpful to know this.
Neon now upgraded to 10.1.
Code in macros.rs needed to be adjusted for the new version of Neon. For example, object property access has changed.
Dependencies like @mapbox/node-pre-gyp also updated.

~Tests for the changes have been added (for bug fixes / features)~

[x] The commit message(s) follow conventional commits
[x] Documentation has been added / updated (for bug fixes / features)
[x] Changes follow the contributing document.

Motivation and Context

Part of MATTR's push to Node 18.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Which merge strategy will you use?

[x] Squash
[ ] Rebase (REVIEW COMMITS)

mate-from-mattr commented 1 year ago

@cowboy-bebug Fixing the clippy related stuff is a good idea, but out of scope for this work item. I agree the repo should lint. It should check formatting