mattrglobal / node-bbs-signatures

An implementation of BBS+ signatures using rust and typescript for node.js
Apache License 2.0
57 stars 23 forks source link

ci: pin python version to 3.10.8 as node-gyp currently depends on it #231

Closed thomas-pearson-mattr closed 3 months ago

thomas-pearson-mattr commented 3 months ago

Description

Required as macos-14 defaults to use python 3.12, this causes issues with node-gyp currently, ubuntu currently uses python 3.10 which is why only macos is failing.

  1. node-gyp depends on distutils package which has now been removed in python version 3.12

ModuleNotFoundError: No module named 'distutils'

CI action link

Could use pip install setuptools to fix this but that doesn't fix the issue below for Node 14

  1. Node@14 will error with the following:

Node gyp ERR - invalid mode: 'rU' while trying to load binding.gyp Where 'U' option is now deprecated

To fix this I downgraded python to get a compatible version

Motivation and Context

Does this PR introduce a breaking change?

Which merge strategy will you use?