mattrglobal / osma

An open source mobile agent for achieving SSI
Apache License 2.0
40 stars 29 forks source link

feat(navigation): change base page to be navigation based #25

Closed tplooker closed 5 years ago

tplooker commented 5 years ago

Short description of what this resolves:

Note - this PR is dependent on #20 being merged ahead of it.

This PR adjusts the base page to be of type NavigationPage so the built in navigation bar can be used when required.

Consistent styling is also applied to the navigation bar.

ConnectionPartialView is removed in place of the re-useable DetailedCell.

Changes proposed in this pull request:

Fixes: #17

michaeldboyd commented 5 years ago

I have built and deployed this code change to an iOS emulator. Although I was not able to test the connection page navigation in ios because the emulator does not have a real camera to scan the qr code, I was able to confirm that the connection page nav works on my android phone. Using gorilla I was able to test the all the other navigation on iOS, which also all works.

One problems exists in iOS. There is no way (that I can find) to navigate out of the QR scanner page. I will create an issue from this.

This PR is ready to merge.

Screen Shot 2019-06-07 at 8 06 35 PM
tplooker commented 5 years ago

Thanks, can you attach a screen shot of the main pages tabbed layout too?

michaeldboyd commented 5 years ago

Is this what you're looking for?

Screen Shot 2019-06-07 at 8 04 04 PM Screen Shot 2019-06-07 at 8 09 02 PM
tplooker commented 5 years ago

Yes, thanks.