search

mattrglobal / pairing_crypto

A library for pairing based cryptography
Apache License 2.0
14 stars 7 forks source link

Obj-c wrapper consolidate argument names #105

Closed zhenwenc closed 1 year ago

zhenwenc commented 1 year ago

Just a few minor consolidation tasks were noticed when implementing the React Native wrapper. :)

Inconsistent argument name casing, I believe camel case should be used here. Note the total_message_count argument:

https://github.com/mattrglobal/pairing_crypto/blob/1b92ff562f85b31507d5fca45fb273c6ffcf6eef/wrappers/obj-c/pairing_crypto/bbs_bls12381_shake256_proof.m#L109-L114

(MAYBE) Both presentationMessage and presentationHeader are been used in the codebase, I think we should make them consistent. I believe presentationHeader is preferred.

https://github.com/mattrglobal/pairing_crypto/blob/09386deae1ba8d62b22cd1cd6049cc74abe6cbf9/wrappers/react-native/ios/PairingCryptoRn.m#L258

dev0x1 commented 1 year ago

Thanks for raising this issue, opened PR #106 to address this.