search

mattrothenberg / vue-flip-toolkit

A Vue.js port of the wonderful react-flip-toolkit by @aholachek
https://keen-davinci-e49eba.netlify.com/
315 stars 17 forks source link

Made compatible with vue 3 #32

Open sebastiandittrich opened 4 years ago

sebastiandittrich commented 4 years ago

As Vue 3 has kept most of the options API the same, it is only one line of code that needs to be changed.

But you have to compile the templates with the new version of vue-template-compiler, otherwise, the components will not work.

Important: I have not updated the dependencies (important for vue-template-compiler), because I think you are also using the same dependencies to build the examples in the stories folder. Since I didn't want to break those and I am not familiar with how rollup works, I kept package.json unchanged.

mattrothenberg commented 3 years ago

@sebastiandittrich I don't understand this change. Won't this be a breaking change for Vue 2.0 users?

jechazelle commented 3 years ago

Do you have any news about vue 3 support ? 🙂

mattrothenberg commented 3 years ago

I don't, @jechazelle . PRs are welcomed!

sebastiandittrich commented 3 years ago

@mattrothenberg Sorry for the confusion, I also do not fully understand what this does exactly, as it was a long time ago. It was also not meant as a 100% complete solution, I just wanted to share my issue and the solution with you. Feel free to delete it if you don't need it.