mattrothenberg / vue-overdrive

Super easy magic-move transitions for Vue apps
684 stars 30 forks source link

Morph Shapes Bug #7

Closed adrianoresende closed 6 years ago

adrianoresende commented 6 years ago

Very cool this effect overdrive. 👏

I found a problem, if change the pages more fast, can happen a bug easily. I believe this behavior of to change pages more fast is common.

mattrothenberg commented 6 years ago

Can you please include a link so I can reproduce this issue on my end?

Thanks!

On Tue, Apr 3, 2018, 19:43 Adriano Resende notifications@github.com wrote:

If change the pages more fast, can happen a bug easily. I believe this behavior of to change pages more fast is common.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/mattrothenberg/vue-overdrive/issues/7, or mute the thread https://github.com/notifications/unsubscribe-auth/AE6PtK8i9va-PwMiZ6GxvzY_biWK9Pc_ks5tlAkSgaJpZM4TF84j .

adrianoresende commented 6 years ago

I tested in first example https://vue-overdrive.netlify.com/#/shapes

mattrothenberg commented 6 years ago

I'm not observing this on my end. Closing for the time being, as this doesn't seem like a "common" issue for others (haven't seen any other issues related to this)

matthiasg commented 6 years ago

Good work, but just clicking through the shapes on my end, at first slowly then alternating very quickly between two states, I also very quickly get into a buggy state where it animates towards the position of a previous dom node.

morph-bug

mattrothenberg commented 6 years ago

@matthiasg Is clicking that fast through the pages significant enough of a use-case that you would classify this as a bug? I'm happy to take a look into this, but I want to make sure it's not an edge case caused by an uncommon user interaction

mattrothenberg commented 6 years ago

@matthiasg @adrianoresende Is this more to your liking? I realized the Netlify link was using a very old version of the library, so I updated it and I think the bug has gone away.

kapture 2018-04-04 at 6 35 34

matthiasg commented 6 years ago

@mattrothenberg did not expect you to fix this right away :) Seems indeed gone, could not reproduce anymore, before it took just a few attempts. 👍

matthiasg commented 6 years ago

@mattrothenberg btw .. as for the bug. in my experience sometimes users to click quickly (especially power users) and it is also an indication that state management is not stable and could fail at any time and is difficult to diagnose then. It definitely doesn't inspire confidence and especially power users would get an impression of fancy graphics gone wrong :)

but in this specific case I just saw @adrianoresende's comment and wanted to second it in so far as I could also reproduce his issue

adrianoresende commented 6 years ago

@mattrothenberg Now this look is beautiful ;) @matthiasg I could have done an animation, you really helped 👍

mattrothenberg commented 6 years ago

Thanks guys, the feedback is much appreciated. Sorry for not understanding the original issue