search

mattroumaya / surveymonkey

Access your SurveyMonkey data directly from R!
https://mattroumaya.github.io/surveymonkey/
Other
42 stars 10 forks source link

Update assemble.R #77

Closed teachinglab closed 2 years ago

teachinglab commented 2 years ago

I'm not sure what issue # this is but this makes parse_survey work. It seems like imap actually iterates over the column names where as map2_dfc was not and I honestly have no idea why.

mattroumaya commented 2 years ago

Thanks @teachinglab! I don't see an issue with merging this, because imap_dfc and map2_dfc should behave similarly, since out has names.

Is parse_survey still not working for you, though? I merged a pull request a few hours ago, and want to make sure that this is still an issue after updating the package. Can you please confirm that you've updated and are still encountering issues, and if so, what you're experiencing?

teachinglab commented 2 years ago

Updated this morning and it had the same issue as before but it works normally now... Might be one of those cases where I was just an RStudio restart away :/

teachinglab commented 2 years ago

Also totally aside here and probably poor github etiquette to ask here but I don't know where else to do it. If I were to write code to cover other parts of the SurveyMonkey API is it best just to keep submitting pull requests for review? not sure how to go about this/if it requires further collaboration.

mattroumaya commented 2 years ago

@teachinglab - please do submit any PRs that you feel will make the API more accessible via R!

The package was developed by @sfirke and his colleagues, but he has since stepped away from the project and I am now the newish maintainer. I welcome any and all collaboration/suggestions you and others have for the package, in hopes that we can keep building on TNTP's work to make the API easier to use.

I'm going to close this PR for now, since I'm not sure it resolves any current issues, but please do not hesitate to open another issue or PR for any bugs or enhancements.