search

mattsaxon / HASS-SpeakercraftMediaPlayer

Speakercraft Platform for Home Assistant
4 stars 1 forks source link

Party Mode turns on all zones (even unconfigured ones) #23

Open mattsaxon opened 2 years ago

mattsaxon commented 2 years ago

This is despite this not occurring via the keypads and the zone being configured to "not follow"

sjeffrey101 commented 2 years ago

odd.

this must be something specific to the control spec, which doesnt work properly. Rather then our code.

ive noticed the events dont fire either when done through the control port. eg i thought i could set a default volume in ez tools by setting an event on zone turn on, but this doesnt work. Annoying!

maybe the use of media_groups can replace the party functionality, if it wont play ball.

mattsaxon commented 2 years ago

I've tried a config like you suggest, but feel it is overly complex to setup. So I like the idea of dealing with this in our code, even if it is a failing on the speakercraft implementation

sjeffrey101 commented 2 years ago

"I've tried a config like you suggest," - is that the media_groups? that are complicated?

i suppose we could have multi zone media_players. the media_player can control the zones allocated to it. And if the status of any zone changes (through keypad, or individual media_player) then the rest could mimic, to stay in sync.

mattsaxon commented 2 years ago

You'd use Universal Media Player probably, and its not so complex when its working, but trying to explain it to someone who just want to install our integration would be too hard IMO.

A further requirement here, for me, is that its consistent with the use of my keypads, where I often invoke party mode from.

So I think easiest fix is that when turning on Party Mode, we can just send off to the unconfigured zones. That's a fairly trivial implementation, but probably does require something like some callback gymnastics as a zone doesn't know about other zones.

sjeffrey101 commented 2 years ago

ok, i dont use party mode at all and dont have any keypads, so not sure on how the 'native' party mode works.

another option is that we implement button presses, as a configuration option. I wonder if do a button press for the party mode button if it works right?

Then for people with out keypads the media_groups could work. I dont see that as been hard for people to implement, no more complex then what they need to enter for our configuration.

mattsaxon commented 2 years ago

Party mode is entered on the keypad by pressing a source button, yes, but you have to hold it for around 3-5 seconds, and I can't see a way of achieving that in the RS232 control specification.