search

mattsaxon / HASS-SpeakercraftMediaPlayer

Speakercraft Platform for Home Assistant
4 stars 1 forks source link

Make entities optional. #32

Closed sjeffrey101 closed 2 years ago

sjeffrey101 commented 2 years ago

Add to configuration a way to make features optional.

suggest that by default the following isnt included.

then we enable by adding to

speakercraft_media: options:

mattsaxon commented 2 years ago

What's the overhead of leaving these entities there?

sjeffrey101 commented 2 years ago

good question. I dont necessarily think there is an overhead, just means lots of entities which may not be needed. particularly the buttons - but these could be useful to someone.

to be honest i dont mind them left in, as they dont need including on dashboards, just thought it was starting to get entity happy.

maybe a non issue. - more work then its worth

mattsaxon commented 2 years ago

My feeling is that is unnecessarily complex. As I've not seen any other components do this, I feel that its a non issue for performance. I also think in the front end, the search is good enough that again it's a non issue

sjeffrey101 commented 2 years ago

ok cool- agree.

should we close this.

mattsaxon commented 2 years ago

Yes, I think so.