search

mattsaxon / HASS-SpeakercraftMediaPlayer

Speakercraft Platform for Home Assistant
4 stars 1 forks source link

No need for early trimming to be a warning #43

Closed mattsaxon closed 2 years ago

mattsaxon commented 2 years ago

I think we've seen enough of this to be sure it's not causing a problem, lets downgrade it to a debug message to clear up our logs

sjeffrey101 commented 2 years ago

only thing with this is that no one should really recieve the message apart from at the start. If this is seen in the log then there is a problem, like its missing serial data.

Happy for you to merge if you want that, but to me i think its a useful message. It doesnt cause me an issue as im in debug any way, and quite honestly i never experience this message.

mattsaxon commented 2 years ago

That's a fair comment, let me rethink, perhaps its a bit more complex to code, but I could look to set a timer and ignore at startup only

sjeffrey101 commented 2 years ago

rather than a timer, what about a flag that gets set when the first surccesful message is recieved. then it sends as a debug when flag is not set and warn when it is set.

mattsaxon commented 2 years ago

New commit made to do exactly as you suggest