search

mattsb42-meta / not-grep

it's like grep, but different
Apache License 2.0
3 stars 5 forks source link

[SUGGESTION]: Change the name? #45

Open YPCrumble opened 3 years ago

YPCrumble commented 3 years ago

First, thanks so much for building this Action! I've been looking for something like this and this IMMEDIATELY solved my problem.

The problem I was encountering is that team members would use constructions like:

class MyClass:
    def some_method(self):
        super(MyClass, self).some_method()  # pylint: disable=super-with-arguments

This is because the developer was used to Python2 and didn't realize that super() is OK to use in Python3.

To my knowledge there's no way to "disable using this disable comment" for one comment - so I was searching for static analysis tools or code-searching tools that I could use for CI to prevent the use of disable=super-with-arguments as it's unnecessary.

Not-Grep solved this perfectly because I simply added super-with-arguments to not-grep and made CI fail if this is ever added to the repo.

Here's the problem - it took way way way too long to find not-grep because what I'm actually looking for is a "code search tool" or a "code grep CI tool" or "static analysis github action" or something similar.

Because this is called "not-grep" it was really hard to find - and I believe most people use this because of the grep functionality.

Maybe something like one of the following would have been easier to find?

In any case, thank you again for building this! If I find any improvements or bugfixes I'll be sure to help add them :D.

YPCrumble commented 3 years ago

Just remembered some more suggestions based on what I had searched for: