search

mattsears / nyan-cat-formatter

Nyan Cat inspired RSpec formatter!
http://mattsears.com/articles/2011/11/16/nyan-cat-rspec-formatter
MIT License
741 stars 81 forks source link

The Nyan Cat Wide Formatter #35

Closed albertbellonch closed 11 years ago

albertbellonch commented 11 years ago

Hello @mattsears.

I've been using this awesome gem for some time, and I ended up missing something: I would like the cat to always reach the end of the terminal, thus replacing the fixed one-column-for-step for a variable value, proportional to the number of tests.

I have added a NyanCatWideFormatter which extends your classical NyanCatFormatter with this new behaviour.

Thanks for your time!

mattsears commented 11 years ago

Thanks so much!

albertbellonch commented 11 years ago

@mattsears You're welcome! Are you planning to release a new gem version any time soon? I would like to use the gem in a clean way. Thanks!

mattsears commented 11 years ago

Yes, very soon. It looks like your pull request broke the 1.8.7 and ree compatibility according to travis: https://travis-ci.org/mattsears/nyan-cat-formatter/builds/4692210

Any idea what it could be?

albertbellonch commented 11 years ago

Awesome!

I just fixed this issue with 1.8.7 and ree, you can see it here.

mattsears commented 11 years ago

Great! I just pushed nyan-cat-formatter 0.3.0 gem. Let me know if you run into any problems.

albertbellonch commented 11 years ago

Yeah, thanks!

Just a quick side note I just noticed: the link to your personal site (in the README) has two errors: its HTTPS and has four 'w', thus looking https://wwww.mattsears.com.

Unless it's some kind of joke, you should change it :)

mattsears commented 11 years ago

Oh, thanks. I will get that fixed. Thanks!