mattsears / stamps

Print stamps with Ruby!
https://github.com/mattsears/stamps
MIT License
47 stars 52 forks source link

#clean_address test failing on ruby 1.9.3 #6

Closed bcm closed 12 years ago

bcm commented 12 years ago
  1) Failure:
test: #clean_address with valid data should indicate if the address match. (AddressTest) [/Users/bcm/Projects/usl/stamps/test/client/address_test.rb:29]:
Failed assertion, no message given.

rvm info: https://gist.github.com/3014649 Gemfile.lock: https://gist.github.com/3014652

It's certainly possible that the failure is due to my having updated dependencies. I haven't had time to dive into this beyond noticing that, at the beginning of the failing test, @address looks like this:

address: {:authenticator=>"ZVk2fjKAIR8AgCYYo+3EQuylEHg=", :address=>{:full_name=>"MATT SEARS", :address1=>"123 MOCKINGBIRD LANE", :address2=>nil, :city=>"NEW YORK", :state=>"NY", :zip_code=>"11111", :zip_code_add_on=>"222", :dpb=>"06", :check_digit=>"5", :urbanization=>nil, :cleanse_hash=>"W9pHbVsNIdYE8/B6SyQ4wOkIIr9kZWFkYmVlZg==20110713", :override_hash=>"PxU7xsTh5+lebMpE9IcjOWQS0alkZWFkYmVlZg==20110713"}, :address_match=>nil, :city_state_zip_ok=>nil, :@xmlns=>"http://stamps.com/xml/namespace/2010/11/swsim/swsimv12"}
mattsears commented 12 years ago

Have you pulled in today's earlier commits? I made a few adjustments earlier today that should resolve this.

bcm commented 12 years ago

oh, no, I hadn't noticed them. I've pulled them in, and they do resolve the issue. closing, thanks!

mattsears commented 12 years ago

Awesome.