mattsmi / clipsgo

Refresh of Keysight/clipsgo, a wrapper and interface for the Go language to CLIPS rules engine.
Apache License 2.0
2 stars 1 forks source link

Bug: not compiling on Mac M1 #1

Open mindreframer opened 3 months ago

mindreframer commented 3 months ago

Hi, thanks for keeping this project up-to-date! I have tried to compile it on a mac m1 laptop, this is the output:

$ make clips_all
.... (lots of compile output)...

gcc -o clips main.o -L. -lclips -lm
ld clips_source/*.o -lm -dylib -arch x86_64 \
                -o clips_source/libclips.so
ld: library not found for -lm
make: *** [clips_source/libclips.so] Error 1
clipsgo|master ⇒

Should I adjust something in the makefile?

mindreframer commented 3 months ago

Here is a kinda working makefile, it does not consider non-ARM Macs

GO                  ?= go
CLIPS_VERSION       ?= 6.31
CLIPS_SOURCE_URL    ?= "https://downloads.sourceforge.net/project/clipsrules/CLIPS/6.31/clips_core_source_631.zip"
MAKEFILE_NAME       ?= makefile
SHARED_INCLUDE_DIR  ?= /usr/local/include
SHARED_LIBRARY_DIR  ?= /usr/local/lib

# platform detection
PLATFORM = $(shell uname -s)

.PHONY: clips clipsgo test install-clips clean

all: clips_source clips clipsgo

clips_source:
    wget -O /tmp/clips.zip $(CLIPS_SOURCE_URL)
    mkdir -p clips_source
    unzip -jo /tmp/clips.zip -d clips_source

ifeq ($(PLATFORM),Darwin) # macOS
clips_source/libclips.dylib: clips_source
    $(MAKE) -f $(MAKEFILE_NAME) -C clips_source \
        CFLAGS="-std=c99 -O3 -fno-strict-aliasing -fPIC" \
        LDLIBS="-lm"
    gcc -shared -o clips_source/libclips.dylib clips_source/*.o -lm -arch arm64

clips_source/libclips.so: clips_source
    $(MAKE) -f $(MAKEFILE_NAME) -C clips_source \
        CFLAGS="-std=c99 -O3 -fno-strict-aliasing -fPIC" \
        LDLIBS="-lm"
    gcc -shared -o clips_source/libclips.dylib clips_source/*.o -lm -arch arm64
else
clips_source/libclips.so: clips_source
    $(MAKE) -f $(MAKEFILE_NAME) -C clips_source \
        CFLAGS="-std=c99 -O3 -fno-strict-aliasing -fPIC" \
        LDLIBS="-lm -lrt"
    ld -G clips_source/*.o -o clips_source/libclips.so
endif

clips: clips_source/libclips.so

clips_all: clips_source clips_source/libclips.so clips

clipsgo: clips
    $(GO) build -ldflags '-r $(SHARED_LIBRARY_DIR)' -o clipsgo ./cmd/clipsgo

just_clipsgo:
    $(GO) build -ldflags '-r $(SHARED_LIBRARY_DIR)' -o clipsgo ./cmd/clipsgo

test: clips
    GODEBUG=cgocheck=2 $(GO) test -coverprofile=cover.out ./pkg/...

coverage: test
    go tool cover -html cover.out

ifeq ($(PLATFORM),Darwin) # macOS
install-clips: clips
    install -d $(SHARED_INCLUDE_DIR)/clips/
    install -m 644 clips_source/*.h $(SHARED_INCLUDE_DIR)/clips/
    install -d $(SHARED_LIBRARY_DIR)/
    install -m 644 clips_source/libclips.dylib \
        $(SHARED_LIBRARY_DIR)/libclips.$(CLIPS_VERSION).dylib
    ln -sf $(SHARED_LIBRARY_DIR)/libclips.$(CLIPS_VERSION).dylib \
        $(SHARED_LIBRARY_DIR)/libclips.6.dylib
    ln -sf $(SHARED_LIBRARY_DIR)/libclips.$(CLIPS_VERSION).dylib \
        $(SHARED_LIBRARY_DIR)/libclips.dylib
    # ldconfig is not used on macOS, you can use install_name_tool if needed
else
install-clips: clips
    install -d $(SHARED_INCLUDE_DIR)/clips/
    install -m 644 clips_source/*.h $(SHARED_INCLUDE_DIR)/clips/
    install -d $(SHARED_LIBRARY_DIR)/
    install -m 644 clips_source/libclips.so \
        $(SHARED_LIBRARY_DIR)/libclips.so.$(CLIPS_VERSION)
    ln -s $(SHARED_LIBRARY_DIR)/libclips.so.$(CLIPS_VERSION) \
        $(SHARED_LIBRARY_DIR)/libclips.so.6
    ln -s $(SHARED_LIBRARY_DIR)/libclips.so.$(CLIPS_VERSION) \
        $(SHARED_LIBRARY_DIR)/libclips.so
    -ldconfig -n -v $(SHARED_LIBRARY_DIR)
endif

clean:
    -rm clips.zip
    -rm -fr clips_source build dist clipspy.egg-info