search

mattsse / chromiumoxide

Chrome Devtools Protocol rust API
Apache License 2.0
787 stars 81 forks source link

Detect more browsers #111

Closed Sytten closed 1 year ago

Sytten commented 1 year ago

Headless chrome added support to detect more browsers (https://github.com/atroche/rust-headless-chrome/blob/aaa6cb03efefbe67996f35802860c6d7fce3b14b/src/browser/mod.rs#L430-L442), do you want me to port those? I don't think this would be an issue, but we probably want to rework the order in which they are tried. The biggest gain is most likely from the support of edge.

mattsse commented 1 year ago

definitely,

the corresponding code is here

https://github.com/mattsse/chromiumoxide/blob/449b35414846f04417d3888f5af4f0d55d7dba43/src/browser.rs#L647-L653

do you want to take this on and reshuffle the order as you see fit?

Sytten commented 1 year ago

Yeah I will push a PR for it and we can discuss it there!

Sytten commented 1 year ago

@mattsse PR is ready for a first review pass!