search

mattsse / chromiumoxide

Chrome Devtools Protocol rust API
Apache License 2.0
755 stars 78 forks source link

Set language to english #113

Closed Sytten closed 1 year ago

Sytten commented 1 year ago

I am not a chrome expert but concerning the README notice for english (A: Check that your chromium language settings are set to English) I am wondering if it would help to pass --lang=en_US to the process?

mattsse commented 1 year ago

I am wondering if it would help to pass --lang=en_US to the process?

oh, didn't know about that option. yes definitly.

Sytten commented 1 year ago

Perfect I can push a PR for that

escritorio-gustavo commented 1 year ago

Was this change applied? The README still mentions the language problem

Sytten commented 1 year ago

No I forgot to do it, its a one line change though if you want to push a pr

escritorio-gustavo commented 1 year ago

Done. I don't really have much experience with PR's, so I hope I did it correctly