Improve the fetcher revision API

mattsse / chromiumoxide

Chrome Devtools Protocol rust API

Apache License 2.0

755 stars 78 forks source link

Improve the fetcher revision API #193

Closed MOZGIII closed 9 months ago

MOZGIII commented 9 months ago

It would also be nice to implement the platform parsing from string, please tell me what you think about it.

MOZGIII commented 9 months ago

I'd argue against since because not every ParseIntError is necessarily a InvalidRevision by definition. It is coincidentally true now, but I don't think we'd want this in the API in a way that looks intentional.

mattsse commented 9 months ago

reasonable