mattsse / chromiumoxide

Chrome Devtools Protocol rust API
Apache License 2.0
712 stars 69 forks source link

fix: Fixed untagged enum deserialization issues #194

Closed Wicpar closed 5 months ago

Wicpar commented 6 months ago

Fixes #167

There is maybe a better way to deserialize, but would not be as simple.

MOZGIII commented 6 months ago

This looks a bit off, let me take a stab at this

MOZGIII commented 6 months ago

Let's add the #[serde(untagged)] variant to the messages enum instead? https://serde.rs/variant-attrs.html#untagged

This should work for a generic "fallback" type.

Wicpar commented 5 months ago

I'm closing this as i no longer encounter the issues in the most recent version