search

mattstauffer / suggestive

Suggestive - take suggestions from the fans/followers of your podcast or blog
MIT License
98 stars 26 forks source link

Remove props sync for topics #24

Closed JacobBennett closed 7 years ago

JacobBennett commented 7 years ago

Replaced synced parent props by creating topics.js object which will handle fetching and updating the topics from the persistence layer, as well as modifying its own state which will be reflected across any other components that are importing it.

JacobBennett commented 7 years ago

related to #20

JacobBennett commented 7 years ago

Inspired by @adamwathan and http://vuejs.org/guide/state-management.html#Simple-State-Management-from-Scratch

JacobBennett commented 7 years ago

Also as an aside here, might need to add this in here for back support

https://github.com/stefanpenner/es6-promise

JacobBennett commented 7 years ago

Okay, think all changes have been made. Also added Promise support for IE<9 (thanks @adamwathan).

JacobBennett commented 7 years ago

Would like to update vue-resource to the newest version to remove the need for wrapping everything in the topics.js in a native Promise as the latest version returns that by default.

JacobBennett commented 7 years ago

Okay, think this is ready for a full review and pull in to suggestive. There are a few other things that we can do a bit later down the road but I will put those in as issues for now. I'm happy with having replaced the topics synced props with the topics.js object for now.

mattstauffer commented 7 years ago

Awesome, gonna try to take a look now!

mattstauffer commented 7 years ago

@JacobBennett are we ready to merge on this or still workign on it? Sorry, can't remember the current status.

JacobBennett commented 7 years ago

all set to go! Thanks @mattstauffer