search

mattstein / snipcart-craft-plugin

A Craft plugin for browsing Snipcart API information from the Craft control panel.
MIT License
29 stars 5 forks source link

The Buck stops here. #5

Closed tobystokes closed 6 years ago

tobystokes commented 6 years ago

For if your not trading in dollar dollar bill y'all, this replaces the $ with relevant currency symbol, as provided by the orders response.

Note the customer API call doesn't actually indicate the currency for its statistics.ordersAmount. In theory you could set it to a recent order.currency value, but as snipcart does actually accept multiple currencies, not 100% sure this would always be true, and seemed better to indicate no symbol than the wrong one?

mattstein commented 6 years ago

Thanks for the cheeky PR title and making the plugin friendlier for the rest of the world, @tobystokes! I considered a "default currency" setting for the plugin, but it seems just as silly to potentially display the wrong currency as it does to not have one at all. Hopefully statistics.ordersAmount will include a currency symbol at some point.