mattstyles / koa-socket

Sugar for connecting socket.io to a koa instance
242 stars 50 forks source link

allows using `app.listen` instead of `app.server.listen` #14

Closed laggingreflex closed 8 years ago

laggingreflex commented 8 years ago

allows using app.listen instead of app.server.listen

app.listen is re-mapped to app.server.listen (only if app.server was created here)

For advanced user (if app.server already existed), it is assumed that they will manually call app.server.listen().

laggingreflex commented 8 years ago

Not too familiar with coverage/tests, but it's pointing to srv.close(), not sure what it means though. Is it asking for that method be put to test as well?

laggingreflex commented 8 years ago

thoughts on this?

mattstyles commented 8 years ago

I'm not sure what its whining about either, but I'm happy with the slight reduction in coverage, I agree, it doesn't look particularly relevant and we can sort it out later when we get more time.

Thanks for the contribution, this makes sense.