app.listen(...) should return an http server instance

mattstyles / koa-socket

Sugar for connecting socket.io to a koa instance

242 stars 50 forks source link

app.listen(...) should return an http server instance #17

Closed farmisen closed 8 years ago

farmisen commented 8 years ago

To keep the api consistent with koa, the patched listen() function should return the created http server. It bite me today when I started to use koa-socket and all my test relying on getting a server instance from app.listen() stopped working. Will provide a PR in a bit.

mattstyles commented 8 years ago

merged and cut with 4.4.0