Upgrade to socket.io 1.7.3

mattstyles / koa-socket

Sugar for connecting socket.io to a koa instance

242 stars 50 forks source link

Upgrade to socket.io 1.7.3 #28

Closed eordano closed 6 years ago

eordano commented 7 years ago

There are a bunch of issues solved since the older version 1.4.3. I had a minor bug in a transitive dependency ws that was fixed by upgrading to the latest stable.

joehecn commented 7 years ago

test ok socket.io-client 1.4.4 => socket.io-client 1.7.3

mattstyles commented 7 years ago

Travis is saying tests are failing, I'm happy to merge this in, just nuke 4 and 5 and start running tests against 6 and 7 and we're good to go with an update. Although, I'm not sure on the current state of socket.io, is it worth upping to v2? how many breaking changes are there?