search

mattstyles / koa-socket

Sugar for connecting socket.io to a koa instance
242 stars 50 forks source link

Added support for HTTPS and custom port on attach. #41

Open StepanZharychev opened 6 years ago

StepanZharychev commented 6 years ago

As was mentioned in one of issues there's no support for HTTPS connection in created socket. I added configuration object for attach method that can accept paths to cert and key, which are required for HTTPS connection. Plus I added ability to specify custom port for socket which can be useful as well to my mind. Please, take a look.

StepanZharychev commented 6 years ago

Please, notice, that Travis that you use is not familiar with rest operator of JS(https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/rest_parameters) and fails on it. While node's supported all ES6 feature for a long time. Seems that you need to update this tester somehow.