search

mattt-b / odin-mode

Emacs major mode for the Odin programming language
28 stars 12 forks source link

Fix single quote #3

Closed terickson001 closed 4 years ago

terickson001 commented 4 years ago

Quick fix for single quotes. The second quote was not highlighted, and character literals containing a double quote (") would begin matching as a string.

terickson001 commented 4 years ago

This actually has an error, " foo 'bar'" doesn't match the last double quote as the closing quote for the string, I'll fix it real quick

mattt-b commented 4 years ago

Thanks for the fix - I added you as a collaborator, you should be able to merge this and push things you may find in the future by yourself - I think.

terickson001 commented 4 years ago

For now, I've just set ' and ` to act as strings. I looked into the cc-mode.el code, and it seems overly complex to handle character literals correctly.

terickson001 commented 4 years ago

I'll need write access for the repo if you'd like me to merge myself.

mattt-b commented 4 years ago

I'll need write access for the repo if you'd like me to merge myself.

Check your email, github says 'awaiting response' from you