mattteochen / IS23-AM10

2023 software engineering project for Polimi
MIT License
1 stars 2 forks source link

Project not building on IJ - ingconti #49

Closed ingconti closed 1 year ago

ingconti commented 1 year ago

I did read readme. b ut would br nice I can use the same logic as other groups.

I downloaded develop branch and tried to run tests: I got

/Users/ingconti/IdeaProjects/IS23-AM10/is23am10/src/main/java/it/polimi/is23am10/App.java:13:27 java: cannot find symbol symbol: variable LogManager location: class it.polimi.is23am10.App

mattteochen commented 1 year ago

Thanks for the feedback, our project is Maven scoped hence it should be IDE-independent. We will look into it ASAP!

ingconti commented 1 year ago

yes, I do see maven settings, but I got an error.

ingconti commented 1 year ago

PS even I use IJ, as said, it uses maven, and in detail tried using mvn cmds inside IJ.

frbuccoliero commented 1 year ago

Hi @ingconti , I downloaded a clean version of IntelliJ Idea (I'm on macos but this shouldn't matter), then cloned a fresh copy of the repo. Build works perfectly:

SCR-20230315-jwp

And then all tests pass (executed from maven right panel): SCR-20230315-jyr

Also mvn package for release works fine: SCR-20230315-jz7

Please note that the JDK used is Amazon Corretto 17, a well-mantained fork of OpenJDK.

ingconti commented 1 year ago

I will give a try, with branch are You using?

About JDK, use whatever want, we do stay with oracle

I will be glad to re-download and try.

On 15 Mar 2023, at 14:24, Francesco Buccoliero @.***> wrote:

Hi @ingconti https://github.com/ingconti , I downloaded a clean version of IntelliJ Idea (I'm on macos but this shouldn't matter), then cloned a fresh copy of the repo. Build works perfectly:

https://user-images.githubusercontent.com/14348908/225320786-b5c32dbb-fb5c-429c-bc38-f647b676fe63.png And then all tests pass (executed from maven right panel): https://user-images.githubusercontent.com/14348908/225321375-767bf0b0-8bd4-44bb-bf7c-446995c27668.png Also mvn package for release works fine: https://user-images.githubusercontent.com/14348908/225321507-41e7ceb5-ea03-48c4-bfd3-0c26529ed689.png Please note that the SDK used is Amazon Corretto 17, a well-mantained fork of OpenSDK.

— Reply to this email directly, view it on GitHub https://github.com/mattteochen/IS23-AM10/issues/49#issuecomment-1470006851, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA64MJ4JJJZY3AXNV6FAAMTW4G7IBANCNFSM6AAAAAAV3VDJDQ. You are receiving this because you were mentioned.

ing. Conti G. Enrico @.*** Ordine Ingegneri di Monza al n. A894 Certing MBB-2430-IT20

PIVA 02119300966
C.FISC. CNTGNR63A23M052W via Duca degli Abruzzi 29 20900 MONZA MB ITALY 0039-039-324723 www.ingconti.com Pec: @.***

CODICE DESTINATARIO KRRH6B9

frbuccoliero commented 1 year ago

with branch are You using?

/develop

About JDK, use whatever want, we do stay with oracle

Sure, thanks. We are using Corretto because of previous experience, but it should be 100% back-compatible with Oracle's OpenJDK, being a fork

ingconti commented 1 year ago

I do have:

Screenshot 2023-03-15 at 16 30 55

but I got:

/Users/ingconti/IdeaProjects/IS23-AM10/is23am10/src/main/java/it/polimi/is23am10/App.java:13:27 java: cannot find symbol symbol: variable LogManager location: class it.polimi.is23am10.App

frbuccoliero commented 1 year ago

Can't really say. I tried from scratch and it all worked, maybe try commenting whatever is causing errors in App.java

ingconti commented 1 year ago

me too. my "clone" is missing "LogManager" as you say.

from specs/ex1:

Ci aspettiamo un progetto Maven:

Compilabile Testabile Eseguibile Senza errori

ingconti commented 1 year ago
image
frbuccoliero commented 1 year ago

LogManager is not a class we defined. It's from the maven plugin Log4j2, it is correctly defined in pom.xml and loaded by Maven. If it's not downloaded by your Maven we can't really do anything.

frbuccoliero commented 1 year ago

Can you check that your maven project successfully imported these two dependencies?

image

ingconti commented 1 year ago

just a note: you select the INNER folder when using IntelliJ?

mattteochen commented 1 year ago

just a note: you select the INNER folder when using IntelliJ?

Good morning, we do not open the folder directly but we open the existing Maven project hence select directly the pom.xml file. IDE does the rest.

frbuccoliero commented 1 year ago

Closing issue following in-person meeting