mattttvaughn / chronicle

GNU General Public License v3.0
219 stars 60 forks source link

Added indicator and option to hide played audiobooks #54

Closed lks-nbg closed 2 years ago

lks-nbg commented 2 years ago

This PR adds a dog-ear for unplayed audiobooks and a filter option in the library menu

There are now three "states" of an audiobook:

Resolves #47, resolves #48

I think the behavior of the toggle_watched button should be changed too since it currently does not allow marking an audiobook as unwatched.

lks-nbg commented 2 years ago

I changed the toggle_watched button behavior but I am not sure if the observer is right. The button basically works and updates the viewCount in the database and and the server.

mattttvaughn commented 2 years ago

Feel free to update that bit in AudiobookDetailsFragment if you want, but not a big sweat. won't cause any performance issues or memory leaks or anything, just a minor code quality thing bordering on personal preference.

If you haven't put up any changes by a day or so I'll go ahead merge and, but if you want to change it after that feel free to just put up another PR

lks-nbg commented 2 years ago

Commit text is false. I added isWatchedIcon in the viewModel and renamed the icon since it is not a white square ;-)