mattttvaughn / chronicle

GNU General Public License v3.0
214 stars 58 forks source link

Feature request: Make all chapter forward/back buttons optional #73

Open JamesDean3 opened 2 years ago

JamesDean3 commented 2 years ago

My media notification for chronicle when collapsed is only showing me 3 buttons, Chapter back, Pause/Play, and Chapter forward, I almost never have real purpose to use the chapter back/forward when everything is working correctly.

When attempting to jump back a few seconds to hear something I missed in my audiobook, muscle memory already caused me to accidentally press the chapter back button instead, and with my luck, instead of going back a single chapter, it went back to the beginning of the book, it did the same when I purposely hit chapter forward (it reset to beginning), when trying to jump forward quickly to figure out where I was at.

Chronicle was showing all chapters correctly for this audiobook, I'm able to jump from chapter to chapter within the chapter list in with no problems, so I'm not sure why it went all the way to the beginning, I'm unable to retrieve more details of the audiobook file at the moment, but that's a separate issue I wanted to make you aware of. Been pretty busy, but if I get some time here soon I will try to get more details on the file and make a separate bug report for that.

Back to the request, I would like to be able to disable the chapter back/forward buttons for every location if possible, when I need to navigate the chapters (rarely do) i'm fine using the chapter list.

On that same note, I also think it would be nice if the seek bar on the notification could be togglable too, or if that isn't possible, maybe if it could just represent the location on the current chapter only, I have accidentally pressed that and lost my spot in the past as well.

Thank you for all your time and work on this app, things are looking great, a lot of the more major bugs have been ironed out and things are looking great.

mattttvaughn commented 2 years ago

Thanks for the suggestion!

Jump forwards/back will return to being primary actions (the ones around pause/play when only 3 are shown) in the next release, that change is already in the codebase. I think that will fix the main issue here.

I do not plan to adding a setting to make chapter buttons optional. I don't think this is the best design to solve the what I imagine is a niche problem. Either removing them from the notification altogether or allowing the user to more easily recover from the issue via a "playback history/bookmarks" on the currently playing screen. I would like to keep the app from devolving into the too-many-niche-settings hell that I see a lot of open source apps end up in.

I am open to changing my mind if I hear more reports of this, I'll leave this issue open for a bit to gauge opinions

JamesDean3 commented 2 years ago

Works for me, as long as the defaults are set back, that will help a lot, noticed that with the way it is now that even my cars back button is pressing the chapter back button instead of the step back button like it used to.

Part of my reasoning for wanting optional chapter back button was for a more immediate fix, figured a history/bookmark feature would already be in the Todo list, but likely wouldn't be around for a while if it isn't already in the works.