Making overholt work with recent dependencies

mattupstate / overholt

Example Flask application illustrating some of my common practices

http://mattupstate.com/blog/how-i-structure-my-flask-applications/

MIT License

1.6k stars 236 forks source link

Making overholt work with recent dependencies #23

Open arnuschky opened 10 years ago

arnuschky commented 10 years ago

1) update of tests

adjust model factories to new Factory-Boy
enable login system for recent Flask-Login (disabled by default for tests)
obtain CSRF token from login form using Flask-Fillin (old method didn't work anymore) 2) update of forms imports for new wtf 3) update all dependencies

mattupstate commented 10 years ago

@arnuschky Thanks for taking the time to do this. My only criticism is that flask.ext is going to be deprecated. There's no reason to use it.

peterdemin commented 10 years ago

@mattupstate, why you say flask.ext is going to be deprecated? I see http://flask.pocoo.org/docs/extensiondev/#extension-import-transition says it's ok.

mattupstate commented 10 years ago

@peterdemin mitsuhiko/flask#1085

arnuschky commented 10 years ago

Ah really? I thought it's the other way 'round. :) Will fix it tonight.

arnuschky commented 10 years ago

I tested this, but none of the release version of the different flask extensions used by overholt seem to support this. It's a recent change, I guess we have to wait for it to trickle down. (flask-security is among them, btw)

mattupstate commented 10 years ago

@arnuschky I'm sorry, but I'm not sure I understand. I use flask_<extension_name> in all my projects.

arnuschky commented 10 years ago

Ah, I misunderstood, sorry. I thought that it changes to flask_ext.<extension_name>. Works now.

arnuschky commented 10 years ago

Rebased previous commits, removed accidentally committed changes to config files.