mattvchandler / ProgressBars

Android countdown / timer app
MIT License
54 stars 8 forks source link

ProgressBars v2.0.3 - The "Notification Settings" feature in the Add new timer section cannot be used. #11

Closed ammarraisafti closed 5 years ago

ammarraisafti commented 5 years ago

Actual behaviour

When adding a new timer. The ability to access the "Notification Settings" feature available in it should be able to be done.

Expected behaviour

The "Notification Settings" feature in the Add new timer section should be accessed or used.

Step to reproduce

Information

Recording of the bug

https://youtu.be/R58ZGutP_Ms

mattvchandler commented 5 years ago

I see that too on 8.0, and I've got a good idea of what's wrong

https://github.com/mattvchandler/ProgressBars/blob/79e4f004ac3ba841f59c9eaf7ef4f9266ae1d74c/app/src/main/java/settings/Settings.kt#L608

This, and a few other places, should be '>= 26'

Let me do some testing to make sure I get them all, and I'll get a patch released

mattvchandler commented 5 years ago

That should fix it. The new version is available here, and should be appearing in play store and fdroid soon.