search

mattvenn / efabless_project_tool

Tool to fetch and parse data about Efabless MPW projects
https://zerotoasiccourse.com
Apache License 2.0
15 stars 3 forks source link

get the list of projects via IP name #5

Closed saicharan0112 closed 1 year ago

saicharan0112 commented 1 year ago

./efabless_tool.py --ip op-amp will list all the projects that has some relation with the op-amp.

The name ignores the character "-", so both "op-amp" and "opamp" are considered while listing down the projects.

If the github url is not found, the efabless project link will be printed out.

Ex:

59    Duy-Hieu Bui                        https://github.com/duyhieubui/caravel_vco_adc.git                               
277   Runkun Li                           [github link not found] https://platform.efabless.com/projects/277
mattvenn commented 1 year ago

Hi Sai! thanks for the PR. I'm not totally sure if this is worth adding because you can already do this like

efabless_tool.py --fields summary --list | egrep -i 'op-?amp'

I like the option to print the efabless project link. Maybe that should be added as a field that can be listed, or listed as default.

Then if we do decide to add that functionality, it should be implemented as the existing code is, eg using fstring instead of %, and using the widths defined at the top of the program, rather than hard-coding them again.

But I think the first thing to decide is whether a search function is useful to add. Why did you add it? Are you not comfortable with pipelines and grep?

saicharan0112 commented 1 year ago

Hi Matt, I thought it would be good to give directly an option just like filter and list cuz it's an important info people usually like to look. I don't think it is required to have the efabless link under the default list. I like how it is now (point to the GitHub by default) cuz there is no imp info on the project in that particular webpage when compared to the github repo itself. Let me know if you would like me to change/add something.

saicharan0112 commented 1 year ago

@mattvenn I implemented your suggestions.

mattvenn commented 1 year ago

thanks for your improvement!