search

mattwar / iqtoolkit

A Toolkit for building LINQ IQueryable providers. This is the official move of my IQToolkit project from CodePlex.
Other
237 stars 77 forks source link

Workaround to issue #17 #20

Closed techseat closed 4 years ago

techseat commented 4 years ago

SQL Formatter writes constant value expressions depend on current culture. Also string operations in some other classes is based on current culture. As current culture is variant based on user Environment (OS) and its options may be changed by end-user, this may lead to generating some critical errors in the formatted SQL sentence's syntax with constant values (specially with cultures with locale-specific decimal separator rather than dot '.' character). For example when we expect SQLFormatter to write constant value 1.5 it may write it in windows with locale French 1,5 or locale Persian(farsi) 1/5 and therefore cannot be executed with this syntax error.

mattwar commented 4 years ago

Can you resubmit this on the master branch? I'm uncertain how to move these changes as cherry-pick fails.

mattwar commented 4 years ago

Nevermind. I was able to merge it.