Open corybrunson opened 3 weeks ago
Coordination with the rest of Tidymodels is underway in ordinal_reg
fork branches of {parsnip} and of {dials}. One tunable parameter is added—the ordinal link function—following the pattern set by the existing survival link function for {censored}.
I think that the first thing to figure out is the parameters for ordinal_reg()
. For slope/intercept models, there are a few to think about:
The "family" (I don't want to use that name) that defines how different logistic models are combined into a multiclass model: "cumulative_logits," "adjacent_categories," "continuation_ratio," or "stopping_patio.". I think that "formulation" or "odds_model" might be good names for this parameter.
The proportionality assumption: "proportional" versus... "disproportional", "non_porportional"?
The link function (e.g. logit, probit, etc)
Once we settle on these main arguments and their names, then we can populate ordinal_reg()
in parsnip and make some engines.
probability_link
or odds_link
for this choice and ordinal_link
for the elementwise link function? I don't know if that characterization extends to all ordinal regression models.ordinal_link
in my fork branch of {dials}, by analogy to survival_link
.
As a new model type and first and probable default engine, my understanding is that these both need to be defined, using separate
make_*()
functions. I've drafted both in this fork branch and raise the issue ahead of submitting a pull request.Should the issue remain open until the entire checklist #3 is completed? If so, then shall we copy the checklist here? (These would be my suggestion.)
(In future, i will raise an issue before doing substantive work, but in this case the work was worth the familiarity-building.)