search

mattwcole / gelf-extensions-logging

GELF provider for Microsoft.Extensions.Logging
MIT License
109 stars 42 forks source link

Add TCP Support (Updated) #69

Closed devn1x closed 2 years ago

devn1x commented 2 years ago

Because there seems to be no update in sight regarding pull request #65, I hope its okay if I try to contribute the last finishing touches to this feature.

Solves #64

mattwcole commented 2 years ago

Fantastic, thanks for tidying up the feature. There is one more small tweak needed, but I don't have permission to modify your PR. I've put it on the old one, would you be able to include it here?

devn1x commented 2 years ago

Okay, I already included your modification and I added permission for you to modify my pr, if you have anything left to add.

Today or tomorrow I will look at the changes once again and if I don't find anything obviously wrong, I will put it up for review.

Also, just so you know and that it's documented somewhere: I did not implement the TCP timeout, because I couldn't get it to work in a clean and reliable way.

mattwcole commented 2 years ago

This is released in v2.5.0-pre1. I'll release a stable version in a few days unless you encounter any issues.

devn1x commented 2 years ago

Thank you so much. I'm going to start implementing this and will report and try to fix any issues that may arise.